Trusted, Bureaucrats
4,228
edits
Changes
m
Switch to the {{gna link}} template to remove dead Gna! links.
<section begin=changes/>
* Updated the [http://www.nmr-relax.com/manual/interatom_unit_vectors.html interatom.unit_vectors user function description] to add the text '3D structure'. This is in response to the http://thread.gmane.org/gmane.science.nmr.relax.user/1547 relax-users mailing list message and the change is to clarify the usage of the user function.
* Created the Noe.test_bug_21591_noe_calculation_fail system test. This is to catch [https://gna.org/bugs/?21591 bug #21591] submitted by [https://{{gna link|url=gna.org/users/mab |text=Martin Ballaschk]}}. This is the complete failure of the NOE analysis. The peak lists attached to the bug report have been included in the test suite to create the system test.
* Improvements for the steady-state NOE analysis overfit_deselect() method. The spin deselection which occurs at the start of the [http://www.nmr-relax.com/manual/calc.html calc user function] call, used to calculate the NOE, is now clearer. Each deselection condition is now explained in detail and the text is now far more informative. In addition, the special condition of all spins being deselected is now caught. If this happens, a RelaxError is raised to prevent the user from going forwards. This should remove confusion as to why the output file is empty.
<section end=changes/>
<section begin=bugfixes/>
* Fix for [https://gna.org/bugs/?21591 bug #21591, the complete failure of the NOE analysis]. This bug was reported by [https://{{gna link|url=gna.org/users/mab |text=Martin Ballaschk]}}. The issue was introduced in the fix for [https://gna.org/bugs/?21562 bug #21562]. The problem is that the overfit_deselect() method was deselecting all spins with two data points or less rather than one or less.
<section end=bugfixes/>