Trusted, Bureaucrats
4,228
edits
Changes
Jump to navigation
Jump to search
Converted all parameters to use parameter templates.
* GUI tests: Addition of the User_functions.test_bug_3_no_argument_validation test. This is to catch [https://sourceforge.net/p/nmr-relax/tickets/3/ bug #3], the absence of user function argument validation within the GUI.
* Unit tests: Addition of two tests for specific_analyses.relax_disp.parameters.param_num(). This is to catch [https://sourceforge.net/p/nmr-relax/tickets/6/ bug #6], the failure of the parameter counting for the 3-site relaxation dispersion models when spins are clustered. The two unit tests are Test_parameters.test_param_num_clustered_spins and Test_parameters.test_param_num_single_spin in the unit test module _specific_analyses._relax_disp.test_parameters.
* Unit tests: Addition of two tests for specific_analyses.relax_disp.parameters.loop_parameters(). The two unit tests are Test_parameters.test_loop_parameters_clustered_spins and Test_parameters.test_loop_parameters_single_spin in the unit test module _specific_analyses._relax_disp.test_parameters. These were added to try to catch the typo error at the end of the function, where the 'dwH_AB' {{:deltaomegaHAB}} parameter appears twice (the second should be 'dwH_AC'{{:deltaomegaHAC}}). However the typo was not caught in the tests as no currently implemented dispersion model contains the 'dwH_AC' {{:deltaomegaHAC}} parameter. Hence it is a latent bug. The tests do catch a minor error with the 'R2eff' model in which the '{{:i0' }} parameter is always returned. '{{:i0' }} should only be returned when exponential curve data is present. This bug has no apparent affect on the current operation of relax, so the parameter is probably handled correctly downstream.* Module specific_analyses.relax_disp.parameters: Fix for loop_parameters() with the 'R2eff' model. This now only returns the '{{:i0' }} parameter when exponential curve data is present. This fix has no apparent affect on the operation of relax, so the '{{:i0' }} parameter is probably correctly handled in code that calls the loop_parameters() function.
* Dispersion: Shift of the model parameters from the parameter loop to lib.dispersion.variables. This removes all references to specific model parameters from the loop_parameters() function in the specific_analyses.relax_disp.parameters module into lib.dispersion.variables. This simplifies the loop_parameters() function and should minimise latent bugs.
* Unit tests: Addition of two tests for specific_analyses.relax_disp.parameters.linear_constraints(). The two unit tests are Test_parameters.test_linear_constraints_clustered_spins and Test_parameters.test_linear_constraints_single_spin in the unit test module _specific_analyses._relax_disp.test_parameters. These show that the linear constraints are correctly assembled for single and clustered spins for all models.
* Module specific_analyses.relax_disp.parameters: Docstring, whitespace, and comment fixes.
* Unit tests: Addition of tests for lib.dispersion.ns_mmq_3site and lib.dispersion.ns_r1rho_3site. These are to catch [https://sourceforge.net/p/nmr-relax/tickets/9/ bug #9], and specifically test for when {{:pA }} is 1.0 and the other probabilities are zero. Two new unit tests of the _lib._dispersion.test_ns_mmq_3site module include Test_ns_mmq_3site.test_ns_mmq_3site_mq and Test_ns_mmq_3site.test_ns_mmq_3site_sq_dq_zq, and a single new unit test of the _lib._dispersion.test_ns_r1rho_3site module is Test_ns_r1rho_3site.test_ns_r1rho_3site.* Unit tests: Addition of two tests for specific_analyses.relax_disp.parameters.param_conversion(). The two unit tests are Test_parameters.test_param_conversion_clustered_spins and Test_parameters.test_param_conversion_single_spin in the unit test module _specific_analyses._relax_disp.test_parameters. These tests uncovered that the {{:pC }} parameter for the 3-site {{:R1rho }} dispersion models 'NS R1rho 3-site' and 'NS R1rho 3-site linear' is not being calculated in the param_conversion() function. This is now reported as [https://sourceforge.net/p/nmr-relax/tickets/11/ bug #11].
* Unit tests: Creation of the Test_parameters.test_param_conversion_clustered_spins_sim test. This is to check the specific_analyses.relax_disp.parameters.param_conversion() function for a cluster of 2 spins for Monte Carlo simulations. It was a failed attempt to catch [https://sourceforge.net/p/nmr-relax/tickets/10/ bug #10]. The problem probably lies in the Monte Carlo simulation setup functions in the specific analysis API rather than in the module specific_analyses.relax_disp.parameters.
* Unit tests: Test of the dispersion specific analysis API function sim_init_values(). This is an attempt at catching [https://sourceforge.net/p/nmr-relax/tickets/10/ bug #10], the failure of the 3-site dispersion models when setting the {{:pC }} parameter for Monte Carlo simulations. The failing test however shows that the sim_init_values() function probably needs a complete overhaul.
* Dispersion: Improved handling of deselected spins in the loop_parameters() function. This is from the specific_analyses.relax_disp.parameters module. The function can now handle the first spins in the cluster being deselected.
* FSFCV configuration: Skip some false positive copyrights in the docs/CHANGES file.
* Dispersion: Fix for [https://sourceforge.net/p/nmr-relax/tickets/7/ bug #7], the model list containing 'No Rex' twice. The MODEL_LIST_FULL variable contained the model 'No Rex' twice. The only manifestation of the bug is a RelaxError message showing the full list of models, when a user selects a non-existent dispersion model.
* Dispersion: Fix for [https://sourceforge.net/p/nmr-relax/tickets/6/ bug #6], the incorrect parameter counting for 3-site models with spin clustering. The issue was that the list of spin-specific parameters was incomplete. To resolve this, the parameter names have been shifted into the lib.dispersion.variables module lists PARAMS_R1, PARAMS_GLOBAL, and PARAMS_SPIN. By removing the parameter names from other parts of relax, the lib.dispersion.variables module will serve as a single point of failure and hence it will much easier to maintain the relaxation dispersion code when new models with new parameters are added.
* Dispersion: Fix for [https://sourceforge.net/p/nmr-relax/tickets/8/ bug #8], the accidental modification of the hardcoded variables. The MODEL_PARAMS lists in specific_analysis.relax_disp.variables were accidentally being modified by the Model_class class in the specific_analyses.relax_disp.model module. The list for a given model was being set as the self.params list. This list would then have the 'r1' parameter pre-pended to it if that parameter is optimised for a model, and hence the specific_analysis.relax_disp.variables list would be permanently modified. Now copy.deepcopy() is being used for all variables to avoid this issue. This bug was uncovered in the unit tests as the _specific_analyses._relax_disp.test_model tests were causing 'r1' to be added, and then the later _specific_analyses._relax_disp.test_parameters tests would fail as 'r1' should not be in those lists. This bug is highly unlikely to be encountered by users of relax. You would need to run two analyses, one after the other without closing relax, and the first analysis would need to have '{{:r1' }} optimised and the second not.* Dispersion: Fix for [https://sourceforge.net/p/nmr-relax/tickets/9/ bug #9], the failure of the 3-site dispersion models when {{:pB }} and {{:pC }} are zero. When both are zero, for example during a comprehensive grid search when model nesting is not utilised, a divide by zero error occurs. This is now caught and large values (1e100) are set for the rates instead.* Dispersion: Fix for [https://sourceforge.net/p/nmr-relax/tickets/11/ bug #11], the missing {{:pC }} calculation for the 3-site {{:R1rho }} models. The models 'NS R1rho 3-site' and 'NS R1rho 3-site linear' were simply missing from the list of models for the {{:pC }} parameter.* Dispersion: Fix for [https://sourceforge.net/p/nmr-relax/tickets/10/ bug #10], the 3-site model failure of setting {{:pC }} for Monte Carlo simulations. For this, the sim_init_values() function of the relaxation dispersion specific API in specific_analyses.relax_disp.api has been completely rewritten. The specific_analyses.relax_disp.parameters.param_conversion() function is now called at the start to generate initial non-model parameters, and at the end to populate the simulation structures. The rest of the function has been stripped down and significantly simplified.
<section end=bugfixes/>
