Trusted, Bureaucrats
4,228
edits
Changes
Jump to navigation
Jump to search
m
→Bugfixes: Internal links.
== Bugfixes ==
* Extremely important fix for the [[B14|model B14]]. This was discovered by author Andrew Baldwin by inspecting his code in relax. Bug #22021: (https://gna.org/bugs/?22021) [[B14|model B14 ]] shows bad fitting to data. The implementation was performed wrong for calculation of g3 and g4. The implementations should be performed by trigonometric functions. The [[B14|model B14 ]] was previously in a state of non-functioning. The [[B14|B14 model ]] now shows excellent performance.
* Fix for bug #22069 by only deleting helix and sheet data with structure.delete when it exists. This is bug #22069 (https://gna.org/bugs/?22069), the failure of the structure.delete user function with "AttributeError: Internal instance has no attribute 'helices'".
* Fix for all edge case 'no [[No Rex' ]] failures of the '[[NS CPMG 2-site expanded' ]] model. This uses the no exchange checking idea, modified to function in the relax trunk, from http://article.gmane.org/gmane.science.nmr.relax.devel/5847. This is importantly on line 1 of the function. The recently introduced set of 7 unit tests comprehensively showing these failures now all pass.
* Important bug fix for the structure.delete user function when multiple models are present. This is to fix bug #22070 (https://gna.org/bugs/?22070), the failure of the structure.superimpose user function after deleting atoms with structure.delete. The problem is that structure.delete was removing the atoms from the first model but none of the others. This is because it was using the structural object atom_loop() method to find the atoms to be deleted, but this method operates on the first model. So when the second model is reached, the atoms are already gone.
= See also =
[[Category:Release_Notes]]
